Not every real estate investment can be a hit out of the park. Cities that are facing population decline, oversupply or economic risks tend to be the worst places to invest in real estate right now.